Skip to content

Remove the default target_project_id when creating merge request #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Toa741 merged 2 commits into from
Oct 17, 2023
Merged

Remove the default target_project_id when creating merge request #540

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76a813f
Remove the default `target_project_id` when creating merge request
PMExtra Oct 13, 2023
f41a59f
Merge branch 'main' into feature/merge-request
Toa741 Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions NGitLab/Impl/MergeRequestClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,11 @@ namespace NGitLab.Impl
public class MergeRequestClient : IMergeRequestClient
{
private readonly API _api;
private readonly int _projectId;
private readonly string _projectPath;

public MergeRequestClient(API api, int projectId)
{
_api = api;
_projectId = projectId;
_projectPath = Project.Url + "/" + projectId.ToStringInvariant();
}

Expand Down Expand Up @@ -89,8 +87,6 @@ public MergeRequest Create(MergeRequestCreate mergeRequest)
if (mergeRequest == null)
throw new ArgumentNullException(nameof(mergeRequest));

mergeRequest.TargetProjectId ??= _projectId;

return _api
.Post().With(mergeRequest)
.To<MergeRequest>(_projectPath + "/merge_requests");
Expand Down