Conversation
Reviewer's Guide by SourceryThis pull request introduces a No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 78.89% 78.97% +0.08%
==========================================
Files 23 24 +1
Lines 1938 1979 +41
Branches 291 294 +3
==========================================
+ Hits 1529 1563 +34
- Misses 284 291 +7
Partials 125 125 ☔ View full report in Codecov by Sentry. |
why: Tests need a reliable way to wait for pane content, especially with different shells what: - Add PaneWaiter class with wait_for_content, wait_for_prompt, wait_for_text methods - Add WaitResult class to handle success/failure/error states - Add comprehensive test suite for waiter functionality
- Fix error propagation in wait_for_content to properly handle timeouts - Add proper type hints and fix mypy errors - Use custom exceptions instead of generic ones in tests - Fix code formatting and line length issues - Update test assertions to match actual error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by Playwright/Selenium/boto3's waiter.
Changes
feat(test): Add PaneWaiter utility for waiting on pane content
why: Tests need a reliable way to wait for pane content, especially with different shells
what:
Summary by Sourcery
Adds a
PaneWaiterutility class for waiting on tmux pane content in tests. This class provides methods for waiting for specific content, prompts, or text within a tmux pane, along with aWaitResultclass to handle the outcome of these operations. It also includes a comprehensive test suite.New Features:
PaneWaiterclass to facilitate waiting for specific content, prompts, or text within a tmux pane during tests, enhancing test reliability, especially when dealing with asynchronous shell operations.WaitResultclass to encapsulate the outcome of wait operations, providing details on success, the resulting value, or any errors encountered.Tests:
PaneWaiterutility, covering scenarios such as waiting for prompts, specific text, handling timeouts, custom error messages, and custom content predicates.Test plan