Skip to content

Fix find item to allow alternate domain to be specified. #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timotheus merged 1 commit into from
Jun 30, 2014
Merged

Fix find item to allow alternate domain to be specified. #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ebaysdk/soa/finditem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Connection(BaseConnection):
SOAP support. FindItemServiceNextGen works fine with standard XML
and lets avoid all of the ugliness associated with SOAP.

>>> from ebaysdk.shopping import Connection as Shopping
>>> from ebaysdk.shopping import Connection as Shopping
>>> s = Shopping(config_file=os.environ.get('EBAY_YAML'))
>>> retval = s.execute('FindPopularItems', {'QueryKeywords': 'Python'})
>>> nodes = s.response_dom().getElementsByTagName('ItemID')
Expand All @@ -36,15 +36,15 @@ class Connection(BaseConnection):
True
"""

def __init__(self, site_id='EBAY-US', debug=False, consumer_id=None,
**kwargs):
def __init__(self, site_id='EBAY-US', debug=False, consumer_id=None,
domain='apifindingcore.vip.ebay.com', **kwargs):

super(Connection, self).__init__(consumer_id=consumer_id,
domain='apifindingcore.vip.ebay.com',
domain=domain,
app_config=None,
site_id=site_id,
debug=debug, **kwargs)

self.config.set('domain', 'apifindingcore.vip.ebay.com')
self.config.set('service', 'FindItemServiceNextGen', force=True)
self.config.set('https', False)
Expand Down Expand Up @@ -79,8 +79,8 @@ def findItemsByIds(self, ebay_item_ids,
'name': rtype
}
})
args = {'id': ebay_item_ids, 'readSet': read_set_node}

args = {'id': ebay_item_ids, 'readSet': read_set_node}
self.execute('findItemsByIds', args)
return self.mappedResponse()

Expand Down Expand Up @@ -109,12 +109,12 @@ def mappedResponse(self):

records.append(mydict)

return records
return records

def find_items_by_ids(self, *args, **kwargs):
return self.findItemsByIds(*args, **kwargs)

def build_request_data(self, verb, data, verb_attrs):
def build_request_data(self, verb, data, verb_attrs):
xml = "<?xml version='1.0' encoding='utf-8'?>"
xml += "<" + verb + "Request"
xml += ' xmlns="http://www.ebay.com/marketplace/search/v1/services"'
Expand Down