feat: testHook returns result ref object#297
Merged
kentcdodds merged 1 commit intotesting-library:masterfrom Feb 12, 2019
Merged
feat: testHook returns result ref object#297kentcdodds merged 1 commit intotesting-library:masterfrom
kentcdodds merged 1 commit intotesting-library:masterfrom
Conversation
kentcdodds
approved these changes
Feb 12, 2019
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
This looks good to me! Thanks @FredyC!
Member
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Added ability to access return value of custom hook call without requiring to use closures for it.
Why: #295 (comment)
How: Using ref object approach similar to
useRefhookChecklist:
No tests were harmed by this change which actually surprised me a lot and my current mental capacity is unable to explain how is it possible 🤕
Fixes #295