Skip to content

Normalize disabling ryuk container#4950

Closed
Koisell wants to merge 1 commit intotestcontainers:mainfrom
Koisell:disable-ryuk
Closed

Normalize disabling ryuk container#4950
Koisell wants to merge 1 commit intotestcontainers:mainfrom
Koisell:disable-ryuk

Conversation

@Koisell
Copy link

@Koisell Koisell commented Jan 24, 2022

Disabling ryuk was only doable using environment variable. This PR aims
to configure it the same way other configuration parameters are.

Disabling ryuk was only doable using environment variable. This PR aims
to configure it the same way other configuration parameters are.
@bsideup
Copy link
Member

bsideup commented Jan 24, 2022

Hi @Koisell,

Thanks for contributing it! We only added an ability to disable Ryuk via env variable so that it can be disabled on exotic CIs (such as BitBucket) and other environments where containers are getting cleaned automatically.

It is not intended to be disabled in "normal" environments, and especially should not be disabled as a project property so that all users of the project will not have it.

What's your use case for disabling Ryuk?

@Koisell
Copy link
Author

Koisell commented Jan 24, 2022

My compagny use Bazel as build tool. In order for cache to work you cannot set environment variables outside of some files. Our CI works without this PR. But since it's a quick submission that could help someone, I decided to go in !

@bsideup
Copy link
Member

bsideup commented Jan 24, 2022

@Koisell sorry, not sure I understood why you need to disable Ryuk from what you shared :)

@Koisell
Copy link
Author

Koisell commented Jan 25, 2022

I need to disable it as my CI/CD based on Jenkins doesn't allow privileged containers.

@eddumelendez
Copy link
Member

As mentioned by @bsideup and discussed internally

We only added an ability to disable Ryuk via env variable so that it can be disabled on exotic CIs (such as BitBucket) and other environments where containers are getting cleaned automatically.

So, I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments