Normalize disabling ryuk container#4950
Conversation
Disabling ryuk was only doable using environment variable. This PR aims to configure it the same way other configuration parameters are.
|
Hi @Koisell, Thanks for contributing it! We only added an ability to disable Ryuk via env variable so that it can be disabled on exotic CIs (such as BitBucket) and other environments where containers are getting cleaned automatically. It is not intended to be disabled in "normal" environments, and especially should not be disabled as a project property so that all users of the project will not have it. What's your use case for disabling Ryuk? |
|
My compagny use Bazel as build tool. In order for cache to work you cannot set environment variables outside of some files. Our CI works without this PR. But since it's a quick submission that could help someone, I decided to go in ! |
|
@Koisell sorry, not sure I understood why you need to disable Ryuk from what you shared :) |
|
I need to disable it as my CI/CD based on Jenkins doesn't allow privileged containers. |
|
As mentioned by @bsideup and discussed internally
So, I'm closing this PR. |
Disabling ryuk was only doable using environment variable. This PR aims
to configure it the same way other configuration parameters are.