Clean up some test assertions and make sure naming is consistent.#2690
Merged
Quinn-With-Two-Ns merged 3 commits intotemporalio:masterfrom Oct 22, 2025
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
temporal-sdk/src/test/java/io/temporal/client/functional/UpdateTestTimeoutTest.java
Show resolved
Hide resolved
.../src/test/java/io/temporal/internal/statemachines/CommandsGeneratePlantUMLStateDiagrams.java
Outdated
Show resolved
Hide resolved
maciejdudko
approved these changes
Oct 21, 2025
Contributor
maciejdudko
left a comment
There was a problem hiding this comment.
A few minor suggestions but otherwise looks fine. LGTM!
temporal-sdk/src/test/java/io/temporal/internal/worker/ActivityFailedMetricsTests.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/internal/worker/ActivityFailedMetricsTests.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/internal/worker/ActivityFailedMetricsTests.java
Outdated
Show resolved
Hide resolved
Comment on lines
+183
to
+184
| assertNotSame( | ||
| "Failure should not be benign", af.getCategory(), ApplicationErrorCategory.BENIGN); |
Contributor
There was a problem hiding this comment.
Suggested change
| assertNotSame( | |
| "Failure should not be benign", af.getCategory(), ApplicationErrorCategory.BENIGN); | |
| assertNotEquals( | |
| "Failure should not be benign", af.getCategory(), ApplicationErrorCategory.BENIGN); |
temporal-sdk/src/test/java/io/temporal/internal/testing/ActivityTestingTest.java
Outdated
Show resolved
Hide resolved
2b69659 to
e0281b4
Compare
e0281b4 to
75f60a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up some test assertions and make sure naming is consistent. This is mostly just applying IDE recommendation for warnings.
Note
Normalize test assertions and class names, and update PlantUML generator references in tests and generated diagrams.
assertEquals(null/true/false, ...)withassertNull/assertTrue/assertFalse, useassertNotEquals/assertInstanceOf, and fix assertion argument order across many tests.import static org.junit.Assert.*).*Testfor consistency (e.g.,UpdateTestTimeoutTest,WarnUnfinishedHandlersTest,WorkflowDescribeTest, various signal/update tests).CommandsGeneratePlantUMLStateDiagramstoCommandsGeneratePlantUMLStateDiagramsTestin tests and generated.pumlheaders.Written by Cursor Bugbot for commit 75f60a9. This will update automatically on new commits. Configure here.