Remove experimental status from worker tuners#2683
Conversation
maciejdudko
left a comment
maciejdudko
left a comment
There was a problem hiding this comment.
Looks good except it also moves poller behavior out of experimental. It's not clear from PR description if it's intentional, and WorkerOptions getters/setters are still experimental.
| */ | ||
| @Experimental | ||
| public interface PollerBehavior {} |
There was a problem hiding this comment.
Is it intentional to also move poller behavior out of experimental too? If so, it's still marked experimental inside WorkerOptions.
There was a problem hiding this comment.
No, this wasn't intentional, good catch. Though, we should probably un-mark it too, but, I'll do that separately for all langs.
maciejdudko
left a comment
maciejdudko
left a comment
There was a problem hiding this comment.
There are two more poller behavior classes that had annotation removed.
| */ | ||
| @Experimental | ||
| public final class PollerBehaviorAutoscaling implements PollerBehavior { |
There was a problem hiding this comment.
This needs to be restored.
| */ | ||
| @Experimental | ||
| public class PollerBehaviorSimpleMaximum implements PollerBehavior { |
There was a problem hiding this comment.
This needs to be restored.
There was a problem hiding this comment.
This one I'll just keep the removal right now honestly, it was never really experimental since this just delegates to the old behavior.
Sushisource
deleted the
codex/remove-experimental-notices-for-worker-tuners
branch
2 participants
Summary
https://chatgpt.com/codex/tasks/task_b_68e97eccfc2883318321fef725cebb09