Added retry options to ActivityInfo. Added ActivityInfo tests.#2622
Merged
maciejdudko merged 1 commit intotemporalio:masterfrom Aug 13, 2025
Merged
Conversation
maciejdudko
force-pushed
the
activity-info-retry-options
branch
from
5b14803 to
0f6827f
Compare
| /** | ||
| * @return Retry options for the Activity Execution. | ||
| */ | ||
| RetryOptions getRetryOptions(); |
Contributor
There was a problem hiding this comment.
What is the behaviour on old servers that don't have this issue temporalio/temporal#6502 resolved?
Contributor
Author
There was a problem hiding this comment.
Default retry options are returned (from RetryOptions.Builder.validateBuildWithDefaults) which would look valid but wouldn't be the real retry policy for the activity. I haven't thought of that case; I guess explicit null would be better?
Contributor
There was a problem hiding this comment.
So for other fields we returned the default, so I think that is fine here. We should be consistent with what is already here. If we were doing the SDK from scratch I would maybe have returned null.
Quinn-With-Two-Ns
approved these changes
Aug 13, 2025
Quinn-With-Two-Ns
approved these changes
Aug 13, 2025
maciejdudko
force-pushed
the
activity-info-retry-options
branch
from
0f6827f to
3a8bd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Feature request: temporalio/features#615
Checklist
Closes Show retry policy on activity info #2481
How was this tested:
New test suite added.