Skip to content

Nexus - Only pass a completion callback if a completion URL is provided #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quinn-With-Two-Ns merged 1 commit into from
Aug 12, 2025
Merged

Nexus - Only pass a completion callback if a completion URL is provided #2615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 36 additions & 31 deletions temporal-sdk/src/main/java/io/temporal/internal/common/InternalUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.fasterxml.jackson.core.JsonProcessingException;
import com.google.common.base.Defaults;
import com.google.common.base.Strings;
import io.nexusrpc.Header;
import io.nexusrpc.handler.HandlerException;
import io.nexusrpc.handler.ServiceImplInstance;
Expand Down Expand Up @@ -88,23 +89,6 @@ public static NexusWorkflowStarter createNexusBoundStub(
HandlerException.ErrorType.BAD_REQUEST,
new IllegalArgumentException("failed to generate workflow operation token", e));
}
// Add the Nexus operation ID to the headers if it is not already present to support fabricating
// a NexusOperationStarted event if the completion is received before the response to a
// StartOperation request.
Map<String, String> headers =
request.getCallbackHeaders().entrySet().stream()
.collect(
Collectors.toMap(
(k) -> k.getKey().toLowerCase(),
Map.Entry::getValue,
(a, b) -> a,
() -> new TreeMap<>(String.CASE_INSENSITIVE_ORDER)));
if (!headers.containsKey(Header.OPERATION_ID)) {
headers.put(Header.OPERATION_ID.toLowerCase(), operationToken);
}
if (!headers.containsKey(Header.OPERATION_TOKEN)) {
headers.put(Header.OPERATION_TOKEN.toLowerCase(), operationToken);
}
List<Link> links =
request.getLinks() == null
? null
Expand All @@ -127,21 +111,42 @@ public static NexusWorkflowStarter createNexusBoundStub(
})
.filter(Objects::nonNull)
.collect(Collectors.toList());
Callback.Builder cbBuilder =
Callback.newBuilder()
.setNexus(
Callback.Nexus.newBuilder()
.setUrl(request.getCallbackUrl())
.putAllHeader(headers)
.build());
if (links != null) {
cbBuilder.addAllLinks(links);
}
WorkflowOptions.Builder nexusWorkflowOptions =
WorkflowOptions.newBuilder(options)
.setRequestId(request.getRequestId())
.setCompletionCallbacks(Collections.singletonList(cbBuilder.build()))
.setLinks(links);
WorkflowOptions.newBuilder(options).setRequestId(request.getRequestId()).setLinks(links);

// If a callback URL is provided, pass it as a completion callback.
if (!Strings.isNullOrEmpty(request.getCallbackUrl())) {
// Add the Nexus operation ID to the headers if it is not already present to support
// fabricating
// a NexusOperationStarted event if the completion is received before the response to a
// StartOperation request.
Map<String, String> headers =
request.getCallbackHeaders().entrySet().stream()
.collect(
Collectors.toMap(
(k) -> k.getKey().toLowerCase(),
Map.Entry::getValue,
(a, b) -> a,
() -> new TreeMap<>(String.CASE_INSENSITIVE_ORDER)));
if (!headers.containsKey(Header.OPERATION_ID)) {
headers.put(Header.OPERATION_ID.toLowerCase(), operationToken);
}
if (!headers.containsKey(Header.OPERATION_TOKEN)) {
headers.put(Header.OPERATION_TOKEN.toLowerCase(), operationToken);
}
Callback.Builder cbBuilder =
Callback.newBuilder()
.setNexus(
Callback.Nexus.newBuilder()
.setUrl(request.getCallbackUrl())
.putAllHeader(headers)
.build());
if (links != null) {
cbBuilder.addAllLinks(links);
}
nexusWorkflowOptions.setCompletionCallbacks(Collections.singletonList(cbBuilder.build()));
}

if (options.getTaskQueue() == null) {
nexusWorkflowOptions.setTaskQueue(request.getTaskQueue());
}
Expand Down
2 changes: 1 addition & 1 deletion temporal-sdk/src/main/java/io/temporal/nexus/WorkflowRunOperationImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public OperationStartResult<R> start(
OperationContext ctx, OperationStartDetails operationStartDetails, T input) {
InternalNexusOperationContext nexusCtx = CurrentNexusOperationContext.get();

WorkflowHandle handle = handleFactory.apply(ctx, operationStartDetails, input);
WorkflowHandle<R> handle = handleFactory.apply(ctx, operationStartDetails, input);

NexusStartWorkflowRequest nexusRequest =
new NexusStartWorkflowRequest(
Expand Down
Loading