Skip to content

When parsing operation token allow a zero version #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quinn-With-Two-Ns merged 1 commit into from
Jul 10, 2025
Merged

When parsing operation token allow a zero version #2591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporal-sdk/src/main/java/io/temporal/internal/nexus/OperationTokenUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public static WorkflowRunOperationToken loadWorkflowRunOperationToken(String ope
throw new IllegalArgumentException(
"Invalid workflow run token: incorrect operation token type: " + token.getType());
}
if (token.getVersion() != null) {
if (token.getVersion() != null && token.getVersion() != 0) {
throw new IllegalArgumentException("Invalid workflow run token: unexpected version field");
}
if (Strings.isNullOrEmpty(token.getWorkflowId())) {
Expand Down
14 changes: 14 additions & 0 deletions temporal-sdk/src/test/java/io/temporal/internal/nexus/WorkflowRunTokenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,20 @@ public void loadWorkflowIdFromOperationToken() {
encoder.encodeToString(json.getBytes())));
}

@Test
public void loadWorkflowIdFromGoOperationToken() {
// This is a token generated by the Go SDK, use this to test compatibility
// across SDKs.
String goOperationToken = "eyJ2IjowLCJ0IjoxLCJucyI6Im5zIiwid2lkIjoidyJ9";

WorkflowRunOperationToken token =
OperationTokenUtil.loadWorkflowRunOperationToken(goOperationToken);
Assert.assertEquals("w", token.getWorkflowId());
Assert.assertEquals("ns", token.getNamespace());
Assert.assertEquals(Integer.valueOf(0), token.getVersion());
Assert.assertEquals(OperationTokenType.WORKFLOW_RUN, token.getType());
}

@Test
public void loadWorkflowIdFromBadOperationToken() {
// Bad token, empty json
Expand Down
Loading