Skip to content

Don't scale down on error if we have never seen a poller decision #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quinn-With-Two-Ns merged 1 commit into from
Jun 27, 2025
Merged

Don't scale down on error if we have never seen a poller decision #2575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions temporal-sdk/src/main/java/io/temporal/internal/worker/PollScaleReportHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ public PollScaleReportHandle(

public synchronized void report(T task, Throwable e) {
if (e != null) {
// We want to avoid scaling down on errors if we have never seen a scaling decision
// since we might never scale up again.
if (!everSawScalingDecision) {
return;
}
if ((e instanceof StatusRuntimeException)) {
StatusRuntimeException statusRuntimeException = (StatusRuntimeException) e;
if (statusRuntimeException.getStatus().getCode() == Status.Code.RESOURCE_EXHAUSTED) {
Expand Down
10 changes: 10 additions & 0 deletions temporal-sdk/src/test/java/io/temporal/internal/worker/PollScaleReportHandleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,16 @@ public class PollScaleReportHandleTest {
public void handleResourceExhaustedError() {
// Mock dependencies
Functions.Proc1<Integer> mockScaleCallback = Mockito.mock(Functions.Proc1.class);
ScalingTask mockTask = Mockito.mock(ScalingTask.class);
ScalingTask.ScalingDecision mockDecision = Mockito.mock(ScalingTask.ScalingDecision.class);
Mockito.when(mockTask.getScalingDecision()).thenReturn(mockDecision);
Mockito.when(mockDecision.getPollRequestDeltaSuggestion()).thenReturn(0);
PollScaleReportHandle<ScalingTask> handle =
new PollScaleReportHandle<>(1, 10, 8, mockScaleCallback);

// Simulate RESOURCE_EXHAUSTED error
StatusRuntimeException exception = new StatusRuntimeException(Status.RESOURCE_EXHAUSTED);
handle.report(mockTask, null);
handle.report(null, exception);

// Verify target poller count is halved and callback is invoked
Expand All @@ -27,10 +32,15 @@ public void handleResourceExhaustedError() {
public void handleGenericError() {
// Mock dependencies
Functions.Proc1<Integer> mockScaleCallback = Mockito.mock(Functions.Proc1.class);
ScalingTask mockTask = Mockito.mock(ScalingTask.class);
ScalingTask.ScalingDecision mockDecision = Mockito.mock(ScalingTask.ScalingDecision.class);
Mockito.when(mockTask.getScalingDecision()).thenReturn(mockDecision);
Mockito.when(mockDecision.getPollRequestDeltaSuggestion()).thenReturn(0);
PollScaleReportHandle<ScalingTask> handle =
new PollScaleReportHandle<>(1, 10, 5, mockScaleCallback);

// Simulate a generic error
handle.report(mockTask, null);
handle.report(null, new RuntimeException("Generic error"));

// Verify target poller count is decremented and callback is invoked
Expand Down
Loading