Fix Workflow.getWorkflowExecution for ExternalWorkflowStub#2529
Merged
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom May 16, 2025
Merged
Fix Workflow.getWorkflowExecution for ExternalWorkflowStub#2529Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom
Conversation
cretz
approved these changes
May 16, 2025
Quinn-With-Two-Ns
force-pushed
the
issue-1237
branch
from
260ad43 to
f1f379d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Workflow.getWorkflowExecution for ExternalWorkflowStub. The docs said this should work but it never has, now it will. Technically a backwards incompatible change, previously it just caused a task failure so this should be fine.
closes #1237