Add an interceptor for listExecutions#2524
Add an interceptor for listExecutions#2524Quinn-With-Two-Ns merged 4 commits intotemporalio:masterfrom
Conversation
Quinn-With-Two-Ns
force-pushed
the
issue-2328
branch
from
5201ff1 to
ae69317
Compare
| import javax.annotation.Nullable; | ||
|
|
||
| class ListWorkflowExecutionIterator | ||
| public class ListWorkflowExecutionIterator |
There was a problem hiding this comment.
Does this need to be public to support the interceptor? In .NET for example we felt there was no need to expose the underlying machinery of list workflows because creating an async iterator (or Java stream) should be easy enough if they must completely replace the logic and not just delegate to the next interceptor.
There was a problem hiding this comment.
ideally no, the problem is the RootWorkflowClientInvoker.java is in internal so it can't be private, moving this class causes a lot of other issues
There was a problem hiding this comment.
moving this class causes a lot of other issues
Hrmm. I wonder making public and moving from io.temporal.client to io.temporal.client.internal would make sense.
There was a problem hiding this comment.
Let me try, I think I had some issue doing that since some other classes in io.temporal.client also have Iterators
There was a problem hiding this comment.
Moved this class and EagerPaginator to internal
Quinn-With-Two-Ns
force-pushed
the
issue-2328
branch
from
ae69317 to
ac93fbf
Compare
2 participants
Add an interceptor for listExecutions
closes #2328