Add support for dynamics workflows to Springboot#2506
Merged
Quinn-With-Two-Ns merged 2 commits intotemporalio:masterfrom May 3, 2025
Merged
Add support for dynamics workflows to Springboot#2506Quinn-With-Two-Ns merged 2 commits intotemporalio:masterfrom
Quinn-With-Two-Ns merged 2 commits intotemporalio:masterfrom
Conversation
cretz
approved these changes
May 2, 2025
| @SuppressWarnings("unchecked") | ||
| private <T> void configureWorkflowImplementation(Worker worker, Class<?> clazz) { | ||
| // Handle dynamic workflows | ||
| if (DynamicWorkflow.class.isAssignableFrom(clazz)) { |
Contributor
There was a problem hiding this comment.
I figure lots of this comes from existing code? I'm guessing there's not a reasonable way to reuse (i.e. maybe we don't want to reference internal packages of another JAR)?
Contributor
Author
There was a problem hiding this comment.
No we don't want to reference internal, it will break Java modules.
Quinn-With-Two-Ns
force-pushed
the
issue-1449
branch
from
5582d84 to
ece42c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for dynamics workflows to Springboot
closes #1449