Support WorkflowImplementationOptionsCustomizer#2503
Support WorkflowImplementationOptionsCustomizer#2503Quinn-With-Two-Ns merged 3 commits intotemporalio:masterfrom
Conversation
There was a problem hiding this comment.
I think if we had thought about this holistically with dynamic workflow versioning, we'd have one solution to customize workflow implementation options at runtime. As of now there is one way for spring, one way for dynamic workflows for only one option, and no way for non-spring, non-dynamic.
There was a problem hiding this comment.
This is not related to runtime customization
This is for customizing workflow implementation options per workflow type at registration time, the Java SDK already supports this, this is just aligning spring boot with the regular Java SDK
There was a problem hiding this comment.
Spring is not getting any special functionality
There was a problem hiding this comment.
I think there could be an overlap to "customize options by workflow type" whether that workflow type is known at registration time or runtime (though runtime obviously gives you more info than workflow type, so not that much overlap).
There was a problem hiding this comment.
Yeah the point is this PR adds registration time customization for Spring which we already have for the Java SDK
Quinn-With-Two-Ns
force-pushed
the
issue-1984
branch
from
297c5c1 to
288bf3a
Compare
Quinn-With-Two-Ns
force-pushed
the
issue-1984
branch
from
288bf3a to
62bc385
Compare
2 participants
Support WorkflowImplementationOptionsCustomizer so users can customize workflow implementation options per type in Springboot
closes #1984