ARM64 build for Test Server#2448
Conversation
Quinn-With-Two-Ns
force-pushed
the
issue-1407
branch
from
8365fd6 to
253c7ee
Compare
| temporal-test-server/build/graal/temporal-test-server* | ||
| !temporal-test-server/build/graal/*.txt | ||
| temporal-test-server/build/native/nativeCompile/temporal-test-server* |
There was a problem hiding this comment.
Can I get confirmation that we believe the release artifact files will have the same name, just with arm ones now? So temporal-test-server_<version>_linux_arm64.tar.gz and temporal-test-server_<version>_maxOS_arm64.tar.gz will now be present?
| // If we're on linux, static link everything but libc. Otherwise link | ||
| // everything dynamically (note the '-' rather than '+' in front of | ||
| // StaticExecutable) | ||
| buildArgs.add(isLinux() ? "-H:+StaticExecutableWithDynamicLibC": "-H:-StaticExecutable") |
There was a problem hiding this comment.
I suspect this may change a tad when we do #2402, specifically that I guess we'll add --libc=musl instead of dynamic libc.
There was a problem hiding this comment.
| buildArgs.add("-H:+UnlockExperimentalVMOptions") | ||
| buildArgs.add("-O4") | ||
|
|
||
| runtimeArgs.add("7233") |
There was a problem hiding this comment.
Can you help me understand this a bit? Does it mean that this is the default arg if not provided? https://graalvm.github.io/native-build-tools/latest/gradle-plugin.html is not very clear to me.
(this is my only blocking concern/comment)
There was a problem hiding this comment.
It sets the arg for ./gradlew -Pagent -PnativeBuild :temporal-test-server:nativeRun since there isn't another way I could find
There was a problem hiding this comment.
So can you confirm this has no affect on the final binary and that the final binary still requires a port and uses that port?
|
Let's goooooooooooo |
Quinn-With-Two-Ns
force-pushed
the
issue-1407
branch
from
204c4a6 to
bf4727d
Compare
3 participants
Create an
ARM64build for time skipping test server. Move us off old palantir graal plugin to the official graal gradle plugincloses #1407