Skip to content

Add high-level workflow describe#2326

Merged
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom
Quinn-With-Two-Ns:issue-2265
Nov 25, 2024
Merged

Add high-level workflow describe#2326
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom
Quinn-With-Two-Ns:issue-2265

Conversation

@Quinn-With-Two-Ns
Copy link
Contributor

closes #2265

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review November 20, 2024 16:39
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner November 20, 2024 16:39
public class WorkflowExecutionDescription extends WorkflowExecutionMetadata {
private final @Nonnull DescribeWorkflowExecutionResponse response;

public WorkflowExecutionDescription(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this constructor package private like its super class? I assume this is public because it is interceptable? Not sure the describe call needs to be interceptable if the list call isn't. Or if we want to make the list call interceptable, we can and then expose the constructor of WorkflowExecutionMetadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is public because it is intercept-able, It was a requirement on the issue. The list call is not intercept-able right now but it makes sense to open an issue to add that as well and expose the constructor of WorkflowExecutionMetadata, but I would prefer to do that in a separate issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue to track making list intercept-able #2328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add high-level workflow describe

3 participants