Skip to content

fix build flag#937

Merged
chaptersix merged 1 commit intomainfrom
alex/fix-releaser
Feb 4, 2026
Merged

fix build flag#937
chaptersix merged 1 commit intomainfrom
alex/fix-releaser

Conversation

@chaptersix
Copy link
Contributor

@chaptersix chaptersix commented Feb 4, 2026

What was changed

Fixed the ldflags path in .goreleaser.yml to correctly set the CLI version at build time.

Before: -X github.com/temporalio/cli/internal.Version={{.Version}}
After: -X github.com/temporalio/cli/internal/temporalcli.Version={{.Version}}

Why?

The Version variable is defined in internal/temporalcli/commands.go, not internal/. The incorrect path meant the ldflags were targeting a non-existent variable, causing all released binaries to show 0.0.0-DEV instead of the actual version.

Checklist

  1. How was this tested:

    • Built with goreleaser build --snapshot --single-target
    • Before fix: temporal version 0.0.0-DEV (Server 1.30.0, UI 2.45.0)
    • After fix: temporal version 1.5.1-SNAPSHOT-31cf9eb (Server 1.30.0, UI 2.45.0)
  2. Any docs updates needed?

    • No

@chaptersix chaptersix marked this pull request as ready for review February 4, 2026 22:53
@chaptersix chaptersix requested review from a team as code owners February 4, 2026 22:53
@chaptersix chaptersix merged commit 6f93d8f into main Feb 4, 2026
8 checks passed
@chaptersix chaptersix deleted the alex/fix-releaser branch February 4, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants