Create versions before setting override, and require Deployment Name for Pinned Override Version #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for Pinned Override Version
carlydf
commented
Jan 14, 2026
|
|
||
| if c.VersioningOverrideBehavior.Value == "pinned" { | ||
| if c.VersioningOverrideDeploymentName == "" && c.VersioningOverrideBuildId == "" { | ||
| if c.VersioningOverrideDeploymentName == "" || c.VersioningOverrideBuildId == "" { |
Contributor
Author
There was a problem hiding this comment.
the error message and the command help text make me think that requiring both flags was the intention all along.
Contributor
Author
There was a problem hiding this comment.
we definitely should not allow deployment name without a build id, which is what the && condition allows
bergundy
approved these changes
Jan 15, 2026
Member
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
Not deeply familiar with the semantics here. Will defer to the matching team for review. You have my rubber stamp though.
ShahabT
approved these changes
Jan 20, 2026
carlydf
added a commit
that referenced
this pull request
Jan 21, 2026
…for Pinned Override Version (#905) <!--- Note to EXTERNAL Contributors --> <!-- Thanks for opening a PR! If it is a significant code change, please **make sure there is an open issue** for this. We work best with you when we have accepted the idea first before you code. --> <!--- For ALL Contributors 👇 --> ## What was changed - Create versions before using them in a Pinned Versioning Override - Require Deployment Name and Build ID flags to be set if override is Pinned. I'm not sure how this worked before, but I don't think we need to support optional deployment name. ## Why? So that CLI works with latest version of server. ## Checklist <!--- add/delete as needed ---> 1. Closes <!-- add issue number here --> 2. How was this tested: <!--- Please describe how you tested your changes/how we can test them --> 3. Any docs updates needed? <!--- update README if applicable or point out where to update docs.temporal.io -->
dandavison
added a commit
that referenced
this pull request
Jan 29, 2026
Backport changes from #905 to work with server v1.30.0-149.0. Server PR temporalio/temporal#9020 added validation that pinned version overrides must reference a version that exists in the task queue. This broke tests that were setting pinned overrides without first registering workers for those versions. Changes: 1. commands.workflow.go: Fix validation to require BOTH deployment name AND build ID for pinned behavior (change && to ||) 2. commands.workflow_test.go: Update versioning override tests to start workers for both version1 and version2 before setting overrides, ensuring versions exist in the task queue 3. commands.workflow_reset_update_options_test.go: Update pinned behavior reset tests to start a versioned worker before attempting reset with pinned override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
So that CLI works with latest version of server.
Checklist
Closes
How was this tested: