Skip to content

Brush component (old PR)#138

Closed
techniq wants to merge 18 commits intomainfrom
brush
Closed

Brush component (old PR)#138
techniq wants to merge 18 commits intomainfrom
brush

Conversation

@techniq
Copy link
Owner

@techniq techniq commented Apr 13, 2024

Brush WIP

[ChartClipPath] Rename includePadding to full to match <Frame>

[Frame] Expose rectEl and forward mousedown and touchstart events

[Brush] Forward mousedown and touchstart events

[Brush] Use SVG/rect instaed of HTML/div

Forward dblclick event

[Brush] Support double clicking on frame to select all, double clicking on range to clear. Move classes to Group contrainers

[Brush] Use domain values for min/max instead of percentages to enable initializing selecction and reduce mapping (pixels <-> domain instead of pixels <-> percent <-> domain)

Cleanup

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 13, 2024

Deploying layerchart with  Cloudflare Pages  Cloudflare Pages

Latest commit: f879a55
Status: ✅  Deploy successful!
Preview URL: https://34bc4ee4.layerchart.pages.dev
Branch Preview URL: https://brush.layerchart.pages.dev

View logs

@vercel
Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
layerchart ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 2:21pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2024

🦋 Changeset detected

Latest commit: f879a55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
layerchart Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner Author

techniq commented Apr 13, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @techniq and the rest of your teammates on Graphite Graphite

@techniq techniq closed this Jun 1, 2024
@techniq techniq changed the title Brush component Brush component (old) Jun 1, 2024
@techniq techniq changed the title Brush component (old) Brush component (old PR) Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant