Add missing table options and full bloom filter#181
Merged
jamesbibby merged 1 commit intotecbot:masterfrom Nov 22, 2019
Merged
Conversation
Contributor
Author
|
@tecbot this should be ready for review. Thanks! |
jamesbibby
approved these changes
Nov 22, 2019
Collaborator
jamesbibby
left a comment
jamesbibby
left a comment
There was a problem hiding this comment.
Looks great, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the rocksdb Partitioned Index Filters wiki page, I noticed that several of the recommended options were not exposed by gorocksdb.
This PR adds those options, as well as a few other options that I noticed were present in the C API but also not exposed:
rocksdb_filterpolicy_create_bloom_full(I'm not clear that this functions differently fromrocksdb_filterpolicy_create_bloomin the version of rocksdb I'm testing against, but it appears to be the recommended setting in the wiki)rocksdb_block_based_options_set_cache_index_and_filter_blocks_with_high_priorityrocksdb_block_based_options_set_pin_top_level_index_and_filterrocksdb_block_based_options_set_index_block_restart_intervalrocksdb_block_based_options_set_metadata_block_sizerocksdb_block_based_options_set_partition_filtersrocksdb_block_based_options_set_use_delta_encodingrocksdb_block_based_options_set_format_versionAll of these options are available in the C API as of the 5.16.fb tag (https://github.com/facebook/rocksdb/blob/5.16.fb/include/rocksdb/c.h). Gorocksdb already wraps the
rocksdb_options_set_enable_pipelined_writefunction that was introduced in this same tagged version (and perhaps others) so I do not anticipate compatibility issues from introducing these methods.