Merged
Conversation
jamesbibby
requested changes
Oct 17, 2019
Collaborator
jamesbibby
left a comment
jamesbibby
left a comment
There was a problem hiding this comment.
One small optimization, otherwise looks great thanks!
CreateNewBackupFlush, when flush is set to true, flushes the WAL before creating the backup. When flush is set to false, it acts exactly like CreateNewBackup and backups the WAL in a separate, non-atomic operation.
kr-mohak
force-pushed
the
backup-improvements
branch
from
960d8d3 to
1c5d8be
Compare
jamesbibby
approved these changes
Oct 19, 2019
Collaborator
jamesbibby
left a comment
jamesbibby
left a comment
There was a problem hiding this comment.
Looks great, thank you for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new methods to BackupEngine: