fix(track-changes): handle ReplaceAroundStep in tracked changes mode (SD-2061)#2225
Merged
harbournick merged 5 commits intomainfrom Mar 3, 2026
Merged
Conversation
SD-2061: When backspacing in tracked changes mode triggers a ReplaceAroundStep (e.g. at paragraph/list boundaries), convert it to a tracked single-character deletion instead of silently applying the structural change. This preserves paragraph numbering, font, and alignment. Also fixes cursor positioning for ReplaceAroundStep transactions by checking selectionPos before tr.selectionSet, and merges adjacent trackDelete marks across run node boundaries so consecutive deletions appear as a single tracked change.
caio-pizzol
requested review from
artem-harbour,
harbournick and
tupizz
and removed request for
harbournick
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e73966a012
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/super-editor/src/extensions/track-changes/trackChangesHelpers/replaceAroundStep.js
Show resolved
Hide resolved
packages/super-editor/src/extensions/track-changes/trackChangesHelpers/replaceAroundStep.js
Show resolved
Hide resolved
Add 9 unit tests covering: - Non-backspace ReplaceAroundStep blocking - Backspace conversion to tracked single-char deletion - selectionPos meta for cursor positioning - findPreviousLiveCharPos skipping tracked-deleted text - Mark merging across run node boundaries (same/different authors) - selectionPos honored in trackedTransaction when tr.selectionSet is false Also add numbering preservation assertion to the existing behavior test for double-backspace at terminal period with bookmark-wrapped runs.
Stop the merge loop at the first live (non-deleted) text node so non-adjacent deletions within the search window are not incorrectly collapsed into a single tracked change.
Increase default assertCommentHighlightExists timeout from 15s to 20s to match what most callers already pass explicitly. Consolidate 4 sequential post-italic assertions into a single composite poll to avoid multiplicative timeouts in webkit's slower rendering pipeline.
harbournick
deleted the
caio/sd-2061-handle-replacearoundstep-in-tracked-changes
branch
Contributor
|
🎉 This PR is included in superdoc-cli v0.2.0-next.62 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc v1.17.0-next.66 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When backspacing in tracked changes mode triggers a
ReplaceAroundStep(e.g. at paragraph/list boundaries), convert it to a tracked single-character deletion instead of silently applying the structural change. This preserves paragraph numbering, font, and alignment.Also fixes cursor positioning for
ReplaceAroundSteptransactions by checkingselectionPosbeforetr.selectionSet, and merges adjacenttrackDeletemarks across run node boundaries so consecutive deletions appear as a single tracked change.