Honor sslmode=disable for db connections (fix TLS regression)#4841
Open
Flamki wants to merge 1 commit intosupabase:developfrom
Open
Honor sslmode=disable for db connections (fix TLS regression)#4841Flamki wants to merge 1 commit intosupabase:developfrom
Flamki wants to merge 1 commit intosupabase:developfrom
Conversation
Author
|
CI status note:
All build/lint/test checks for this change are green. |
Pull Request Test Coverage Report for Build 21875711915Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
CLI 2.75.x attempts a TLS connection even when
sslmode=disableis set in--db-url, causingtls error (server refused TLS connection). The same command succeeds with--debugbecause TLS is disabled there.Issue: #4839 (regression of #4288)
What is the new behavior?
When
sslmode=disableis present in the connection string, the CLI explicitly disables TLS, so non‑TLS self‑hosted databases connect successfully without needing--debug.Additional context
This aligns normal behavior with the
--debugpath, which already disables TLS. No user‑visible changes beyond respectingsslmode=disable.