init commit to fix speed issues with mimic3 test cases#607
Merged
Conversation
dalloliogm
pushed a commit
to dalloliogm/PyHealth
that referenced
this pull request
Nov 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the MIMIC-III dataset test suites to use local test resources instead of downloading data from PhysioNet, and enhances the test output with informative logging and improved assertions. The changes simplify setup and teardown procedures, improve reliability, and make test results easier to interpret.
Test setup and data source changes:
test_mimic3.pyandtest_mimic3_mortality_prediction.pynow use a local path (test-resources/core/mimic3demo) for the MIMIC-III demo dataset, removing all code related to downloading, extracting, and cleaning up remote data. This makes tests faster and more reliable. [1] [2]Logging and output improvements:
Test logic and assertions:
Simplification and cleanup:
tempfile,shutil,subprocess) and related code from both test files, streamlining the test codebase. [1] [2]Test coverage adjustments:
noteeventsare not included in the local test resources, clarifying the scope of the test suite.