Refactoring: fix SonarQube issues in populateMap()

[Simulant87]

#984

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stleary]

Method validation now requires two function calls: getKeyNameFromMethod() and isValidMethod(). Also, the validation check is performed twice, in isValidMethod(), and in populateMap() with the key check. The call to isValidMethod() could be moved back up to the original location in populateMap(). This will help restore a bit of performance without losing all of the cognitive load improvements.

[Simulant87]

I am not 100% sure, how you want to build it.
moving the extracted method isValidMethod() back into the for loop of populateMap() would either indent everything back into an if-statement, which I removed. And reintroducing it would increase the cognitive load again. Or it would introduce an early exit continue; into the for loop, which would be bad for performance as it introduces an unpredictable jump. I tried to avoid both.

[stleary]

@Simulant87 Thanks for working on this issue. One minor comment, otherwise looks good.

[stleary]

What problem does this code solve?
Refactor JSONObject populateMap(), per #984.

Note: There is an outstanding comment. If the submitter can't make the update, the code will be merged anyway, and I will add a follow-up PR to fix it.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
Yes, that was why the issue was created.

Review status
APPROVED

Starting 3-day comment window

[Simulant87]

I think I could have a look at it maybe tomorrow. But you could as well merge it already and I could create another PR.