Skip to content

Conversation

@marilynel
Copy link
Contributor

Fixes issue #943

@stleary
Copy link
Owner

stleary commented Mar 24, 2025

What problem does this code solve?
Parses CDL docs that fail to include a newline and have a missing final value on the final line.
While this is a change in behavior, it should only affect CDL files that meet the above conditions.
Missing the final newline could happen unintentionally, and users may never notice that the last
row was omitted.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, a new unit test was added.

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3 day comment window

@stleary stleary closed this Mar 27, 2025
@stleary stleary reopened this Mar 27, 2025
@stleary stleary merged commit 4917e35 into stleary:master Mar 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants