Skip to content

Removing unneeded synchronization #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stleary merged 1 commit into from
Oct 4, 2023
Merged

Removing unneeded synchronization #774

stleary merged 1 commit into from
Oct 4, 2023

Conversation

@mccartney
Copy link
Contributor

@mccartney mccartney commented Sep 30, 2023

Fixes #765

@stleary
Copy link
Owner

stleary commented Oct 1, 2023

What problem does this code solve?
Removes some unneeded synchronization code. The sync code has been in place for 10 years, but seems unnecessary.

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

@stleary stleary mentioned this pull request Oct 1, 2023
Closed
@kofemann
Copy link

kofemann commented Oct 1, 2023

Thanks! 🚀

@stleary stleary merged commit 79af389 into stleary:master Oct 4, 2023
@stleary stleary changed the title Removing excessive synchronization Removing unneeded synchronization Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stleary stleary stleary approved these changes

+1 more reviewer

@johnjaylward johnjaylward johnjaylward approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Weird synchrinization blocks

4 participants

@mccartney @stleary @kofemann @johnjaylward