Replace Collection<Object> to Collection<?> (wildcard).#114
Closed
TimReset wants to merge 1 commit intostleary:masterfrom
Closed
Replace Collection<Object> to Collection<?> (wildcard).#114TimReset wants to merge 1 commit intostleary:masterfrom
TimReset wants to merge 1 commit intostleary:masterfrom
Conversation
Otherwise List<?> will call JSONArray(Object array) but is not right.
Owner
|
Evaluating, will get back to you soon. No worries on the English. Thanks, Sean |
Owner
|
Please see pull requests 111 and 112, which proposed a similar implementation. |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise List<?> will call JSONArray(Object array) but is not right.
Example:
List<?> list = new ArraysList();
JSONArray array = new JSONArray(list);
With old code this call JSONArray(Object array) and then throw exception ( throw new JSONException("JSONArray initial value should be a string or collection or array.");) But is not right! JSONArray(Collection collection) will be call! With wildcard that be work.
P.S. Sorry for my English.