Skip to content

Conversation

@Om-A-osc
Copy link
Contributor


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames
    status: passed
  • task: lint_editorconfig
    status: passed
  • task: lint_markdown
    status: na
  • task: lint_package_json
    status: passed
  • task: lint_repl_help
    status: na
  • task: lint_javascript_src
    status: na
  • task: lint_javascript_cli
    status: na
  • task: lint_javascript_examples
    status: na
  • task: lint_javascript_tests
    status: na
  • task: lint_javascript_benchmarks
    status: na
  • task: lint_python
    status: na
  • task: lint_r
    status: na
  • task: lint_c_src
    status: na
  • task: lint_c_examples
    status: na
  • task: lint_c_benchmarks
    status: na
  • task: lint_c_tests_fixtures
    status: na
  • task: lint_shell
    status: na
  • task: lint_typescript_declarations
    status: passed
  • task: lint_typescript_tests
    status: na
  • task: lint_license_headers
    status: passed

Description

While investigating a separate issue, I ran make lint-pkg-json and found that the lint_package_json check was failing for one of the packages.

The failure was caused by a missing devDependencies field in package.json. According to the package.json schema enforced by the linting pipeline, devDependencies is a required field. As a result, the Ajv schema validator was flagging this omission as an error.

This pull request fixes the issue by adding the appropriate devDependencies field, bringing the package metadata back into compliance with the schema and allowing the lint step to pass.

Related Issues

None.

Questions

No.

Other

No.

Checklist

AI Assistance

  • Yes
  • No

@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Jan 20, 2026
@Om-A-osc
Copy link
Contributor Author

Hi @kgryte and @Planeshifter, please review and merge when convenient. All package-json lints are passing now.
Thanks!

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Jan 22, 2026
@Planeshifter Planeshifter changed the title Chore: addresses missing devdep causing lint error in docs/migration-guides/tfjs/package.json chore: add missing devDependencies field Jan 22, 2026
Planeshifter
Planeshifter previously approved these changes Jan 22, 2026
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 22, 2026
@socket-security
Copy link

socket-security bot commented Jan 22, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: Unsafe defaults in npm remark-html``

CVE: GHSA-9q5w-79cv-947m Unsafe defaults in remark-html (CRITICAL)

Affected versions: = 14.0.0; < 13.0.2; >= 14.0.0 < 14.0.1

Patched version: 13.0.2

From: package.jsonnpm/remark-html@10.0.0

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/remark-html@10.0.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 22, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 22, 2026

PR Commit Message

chore: add missing `devDependencies` field

PR-URL: https://github.com/stdlib-js/stdlib/pull/9840

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Om-A-osc Om-A-osc force-pushed the chore/tfjs/package.json branch from 7f3a969 to 05dccf3 Compare January 23, 2026 09:03
@Om-A-osc Om-A-osc requested a review from Planeshifter January 23, 2026 09:17
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants