Make methods in times available at the top level of human_readable#528
Merged
staticdev merged 1 commit intostaticdev:mainfrom Jan 29, 2023
Merged
Make methods in times available at the top level of human_readable#528staticdev merged 1 commit intostaticdev:mainfrom
staticdev merged 1 commit intostaticdev:mainfrom
Conversation
This is a fix for staticdev#526. This makes methods in times available at the top level of human_readable. Until now, `date_time` and `precise_delta` were imported, but the following methods were not available -- contrary to the content of the documentation. - time_delta - time_of_day - timing - year - day - date This PR makes these methods available at the top level of human_readable. It's just adding them to `__all__` in `human_readable/__init__.py`. # result ```python >>> import human_readable >>> human_readable.time_delta <function time_delta at 0x1007bf420> >>> ```
staticdev
requested changes
Jan 29, 2023
Owner
staticdev
left a comment
staticdev
left a comment
There was a problem hiding this comment.
That is perfect, thanks. Do you mind also adding listing from lists. I noticed it is also missing.
Contributor
Author
|
@staticdev Thank you for your review! https://github.com/staticdev/human-readable/pull/528/files#diff-14364be259734ce659f5922beca8a91e5b0118b264540fef8b7310f8ffc6124bR5 It seems that |
staticdev
approved these changes
Jan 29, 2023
Owner
|
My mistake @kitsuyui. I will approve as soon as the checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #526. This makes methods in times available at the top level of human_readable. Until now,
date_timeandprecise_deltawere imported, but the following methods were not available -- contrary to the content of the documentation.This PR makes these methods available at the top level of human_readable. It's just adding them to
__all__inhuman_readable/__init__.py.result
Note
If my PR is not appropriate and you can do it directly, please do so without hesitation.
(Please choose the way that is easier for you)