catch Stan log_prob exceptions inside moment matching#262
Merged
Conversation
jgabry
requested changes
Mar 19, 2024
Member
jgabry
left a comment
There was a problem hiding this comment.
This seems like a good idea. I made a few small suggestions in review comments.
Co-authored-by: Jonah Gabry <jgabry@gmail.com>
Member
Author
|
Thanks for fixes! I need to remember to run tests in fresh R session. I was learning |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 92.77% 92.68% -0.10%
==========================================
Files 31 31
Lines 2836 2842 +6
==========================================
+ Hits 2631 2634 +3
- Misses 205 208 +3 ☔ View full report in Codecov by Sentry. |
jgabry
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #261
When doing moment matching steps, catch the errors when evaluating log_prob, and break out without an error. This will allow getting moment matching results for all the non-failing observations and may get some moment matching also for the failing ones.