feat(splunk): add FILE_ACCESS violation support to Splunk TA API#19496
Draft
Stringy wants to merge 2 commits intogiles/enable-splunk-ta-testsfrom
Draft
feat(splunk): add FILE_ACCESS violation support to Splunk TA API#19496Stringy wants to merge 2 commits intogiles/enable-splunk-ta-testsfrom
Stringy wants to merge 2 commits intogiles/enable-splunk-ta-testsfrom
Conversation
The Splunk TA API silently dropped FILE_ACCESS violations — the type fell through to UNKNOWN and all file-specific data was lost. - Add FILE_ACCESS to ViolationType enum and FileAccessInfo message - Extract file paths, operation, metadata, hostname, and process info - Fall back to FileAccess.timestamp when Alert_Violation.time is nil Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at d3945f5. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## giles/enable-splunk-ta-tests #19496 +/- ##
================================================================
- Coverage 49.27% 49.26% -0.01%
================================================================
Files 2726 2725 -1
Lines 205626 205636 +10
================================================================
+ Hits 101314 101316 +2
- Misses 96775 96782 +7
- Partials 7537 7538 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Stringy
force-pushed
the
giles/fam-violations-in-splunk-ta
branch
from
0a85ba8 to
d3945f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Splunk TA API silently dropped FILE_ACCESS violations — the type fell through to UNKNOWN and all file-specific data was lost.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!