Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19492 +/- ##
==========================================
- Coverage 49.27% 49.26% -0.01%
==========================================
Files 2726 2726
Lines 205626 205625 -1
==========================================
- Hits 101313 101309 -4
- Misses 96778 96779 +1
- Partials 7535 7537 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dvail
left a comment
There was a problem hiding this comment.
Can't wait to try this out.
We should add the konflux-build label to this PR too to make sure everything looks good in that environment as well.
It also might make sense to take a look at ui/apps/platform/scripts/check-optional-dependency-versions.js. I'm not sure how much of that (if any) will remain relevant.
|
@pedrottimark: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Aha, some related
deDependenciesdo not yet include 8 in their peer dependencies.I will replace with upgrade to vite 7 instead.
https://vite.dev/blog/announcing-vite8
https://vite.dev/guide/migration#migration-from-v7
To reduce risk, I deferred the following upgrade that I mentioned in #19462
https://github.com/vitejs/vite-plugin-react/releases/tag/plugin-react%406.0.0
Change
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run testin ui/apps/platform folder.npm run startin ui/apps/platform folder with staging demo as central.