Merged
Conversation
mtodor
force-pushed
the
mtodor/ROX-31477-add-stackrox-client
branch
6 times, most recently
from
79b040c to
0f4dbd3
Compare
mtodor
changed the title
janisz
reviewed
Nov 21, 2025
janisz
reviewed
Nov 21, 2025
janisz
reviewed
Nov 21, 2025
janisz
approved these changes
Nov 21, 2025
mtodor
force-pushed
the
mtodor/ROX-31475-add-mcp-server
branch
from
5650c9e to
717e85e
Compare
mtodor
force-pushed
the
mtodor/ROX-31477-add-stackrox-client
branch
from
0f4dbd3 to
0e40148
Compare
janisz
approved these changes
Nov 24, 2025
mtodor
force-pushed
the
mtodor/ROX-31475-add-mcp-server
branch
from
717e85e to
2b544e3
Compare
mtodor
force-pushed
the
mtodor/ROX-31477-add-stackrox-client
branch
from
0e40148 to
973693b
Compare
mtodor
force-pushed
the
mtodor/ROX-31477-add-stackrox-client
branch
from
973693b to
48c56e0
Compare
janisz
added a commit
that referenced
this pull request
Mar 17, 2026
Move cancellable context creation to the beginning of Run() so that the entire server lifecycle, including the client connection, can be properly cancelled. This allows graceful shutdown to interrupt the connection phase if needed. The signal handler is also set up earlier to ensure interrupts are caught as soon as possible. Addresses PR #50 review comment #5 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is adding StackRox Client.
It's adding the following functionalities:
insecureoption is renamed toinsecure_skip_tls_verifyto be more understandable and similar to other toolsFile:
internal/toolsets/config/tools.go- Besides that it also adds an example implementation oflist_clusterstool. Purpose of that is to simply test the full flow. Proper implementation oflist_clusterstool will be done in a followup PR.