This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Add support for runtime override of dashboard url.#1088
Merged
Conversation
JAORMX
approved these changes
Feb 18, 2025
Contributor
JAORMX
left a comment
JAORMX
left a comment
There was a problem hiding this comment.
Seems like a reasonable first step and it would unblock me
Contributor
|
agree, looks like a pragmatic solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened this PR to discuss whether we want to do it and, if so, to keep it as simple as possible.