chore(volume): Add nil pointer checks and tests for outputResult func…#623
Merged
rubenhoenle merged 1 commit intomainfrom Feb 25, 2025
Merged
chore(volume): Add nil pointer checks and tests for outputResult func…#623rubenhoenle merged 1 commit intomainfrom
rubenhoenle merged 1 commit intomainfrom
Conversation
marceljk
reviewed
Feb 21, 2025
marceljk
reviewed
Feb 21, 2025
Contributor
|
stackit-cli/internal/cmd/beta/volume/delete/delete.go Lines 59 to 64 in 31084ad Could you add an additional check here if the volume name is empty? If it's empty, it should use the volumeId as label This would solve this issue #574 |
…tions Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
31084ad to
99fc799
Compare
marceljk
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #574