Skip to content

chore(volume): Add nil pointer checks and tests for outputResult func…#623

Merged
rubenhoenle merged 1 commit intomainfrom
ft/add-nil-checks-volume
Feb 25, 2025
Merged

chore(volume): Add nil pointer checks and tests for outputResult func…#623
rubenhoenle merged 1 commit intomainfrom
ft/add-nil-checks-volume

Conversation

@Fyusel
Copy link
Copy Markdown
Contributor

@Fyusel Fyusel commented Feb 21, 2025

fixes: #574

@marceljk
Copy link
Copy Markdown
Contributor

volumeLabel, err := iaasUtils.GetVolumeName(ctx, apiClient, model.ProjectId, model.VolumeId)
if err != nil {
p.Debug(print.ErrorLevel, "get volume name: %v", err)
volumeLabel = model.VolumeId
}

Could you add an additional check here if the volume name is empty? If it's empty, it should use the volumeId as label
This would solve this issue #574

…tions

Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@Fyusel Fyusel force-pushed the ft/add-nil-checks-volume branch from 31084ad to 99fc799 Compare February 24, 2025 11:15
@rubenhoenle rubenhoenle merged commit b5c5cad into main Feb 25, 2025
3 checks passed
@rubenhoenle rubenhoenle deleted the ft/add-nil-checks-volume branch February 25, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli: stackit volume delete prints empty name

3 participants