Skip to content

chore(objectstorage): migrate to new SDK structure#1348

Merged
cgoetz-inovex merged 1 commit intomainfrom
chore/STACKITCLI-369-objectstorage-sdk-migration
Mar 25, 2026
Merged

chore(objectstorage): migrate to new SDK structure#1348
cgoetz-inovex merged 1 commit intomainfrom
chore/STACKITCLI-369-objectstorage-sdk-migration

Conversation

@rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Mar 25, 2026

Description

relates to STACKITCLI-369

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner March 25, 2026 12:50
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/create 38.30% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/delete 28.95% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/describe 66.67% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/list 42.86% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/create 56.76% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/delete 34.38% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/list 62.79% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/create 58.82% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/delete 39.02% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/list 61.11% (-0.43%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/disable 29.41% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/enable 29.41% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/object-storage/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/object-storage/utils 96.77% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/create/create.go 38.30% (ø) 47 18 29
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/delete/delete.go 28.95% (ø) 38 11 27
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/describe/describe.go 66.67% (ø) 39 26 13
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/list/list.go 42.86% (ø) 49 21 28
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/create/create.go 56.76% (ø) 37 21 16
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/delete/delete.go 34.38% (ø) 32 11 21
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/list/list.go 62.79% (ø) 43 27 16
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/create/create.go 58.82% (ø) 51 30 21
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/delete/delete.go 39.02% (ø) 41 16 25
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/list/list.go 61.11% (-0.43%) 54 (+2) 33 (+1) 21 (+1) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/disable/disable.go 29.41% (ø) 34 10 24
github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/enable/enable.go 29.41% (ø) 34 10 24
github.com/stackitcloud/stackit-cli/internal/pkg/services/object-storage/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/object-storage/utils/utils.go 96.77% (ø) 31 30 1

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/bucket/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials-group/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/credentials/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/disable/disable_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/object-storage/enable/enable_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/object-storage/utils/utils_test.go

@cgoetz-inovex cgoetz-inovex merged commit 36fff24 into main Mar 25, 2026
3 checks passed
@cgoetz-inovex cgoetz-inovex deleted the chore/STACKITCLI-369-objectstorage-sdk-migration branch March 25, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants