Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
rubenhoenle
reviewed
Mar 24, 2026
s-inter
commented
Mar 25, 2026
Member
|
Please include the test setup next time in your testing instructions. Could have been e.g. resource "stackit_kms_keyring" "example" {
project_id = var.project_id
display_name = "example-name"
description = "example description"
}
resource "stackit_kms_key" "key" {
project_id = var.project_id
keyring_id = stackit_kms_keyring.example.keyring_id
display_name = "key-01"
protection = "software"
algorithm = "aes_256_gcm"
purpose = "symmetric_encrypt_decrypt"
}
output "env" {
value = "export KEYRING_ID=${stackit_kms_keyring.example.keyring_id} && export KEY_ID=${stackit_kms_key.key.key_id} && KEY_SA_EMAIL=${var.service_account_email}"
}
Testing instructions:
Edit: Testing instructions should also include the teardown of the test setup |
rubenhoenle
approved these changes
Mar 27, 2026
… and ACL updates to align with create command
80f7f4d to
b9520c8
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements KMS key options for secrets manager instance commands (create, update, describe).
Changes
--kms-key-id,--kms-keyring-id,--kms-key-version, and--kms-service-account-emailflags tostackit secrets-manager instance createandstackit secrets-manager instance updatecommands.stackit secrets-manager instance describecommand.Testing Instructions
Prerequisite: Run
make build(if needed)1.
instance create(with KMS options)KmsKeyproperties.KMS KEY ID,KMS KEYRING ID,KMS KEY VERSION, andKMS SERVICE ACCOUNT EMAIL.2.
instance updateUpdate Name Only
describereflects the new name.Update Name & ACLs Together
describereflects both changes.Update KMS Options (requires
--name)describereflects the new KMS values.3. Edge Cases & Negative Tests
--name: Error"--name is required when using KMS flags"--nameor--aclprovided: Error about missing required fields.Notes for Reviewers
updatenow supports updating instance name, ACLs, and KMS settings (separately or together).--nameis required when using any KMS flags.--nameor--aclmust be provided.UpdateInstance; ACLs useUpdateACLs.UpdateInstancesucceeds butUpdateACLsfails, the user gets a helpful error indicating partial success.relates to STACKITCLI-338
Checklist
make fmtmake generate-docsmake testmake lint