Fix avoidable exception when data length is too long#823
Fix avoidable exception when data length is too long#823WojciechNagorski merged 4 commits intosshnet:developfrom
Conversation
…r than int.maxvalue are ignored and do not throw an exception
IgorMilavec
left a comment
There was a problem hiding this comment.
You should change/remove test Load_ShouldThrowNotSupportedExceptionWhenDataLengthIsGreaterThanInt32MaxValue for this PR to pass.
|
I have removed the unit test as I cannot think of a way to enter into the middle condition, Perhaps this condition should be removed entirely. |
|
With the current implementation of SshData I believe you cannot test this case. |
|
Fix #713 added to first comment as requested |
WojciechNagorski
left a comment
There was a problem hiding this comment.
LGTM!
I wish there was a test, but I know it will be difficult.
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
Fix #713
Fix #1243
Data lengths that are both longer than int.MaxValue and data bytes are now ignored and do not throw an exception.
This would come up when connecting to a Tectia SFTP server running on a mainframe.
Credit to @edmlin for the fix. This is for issue #713