Use ExceptionDispatchInfo to retain call stack in AsyncResult.EndInvoke()#1470
Merged
Rob-Hague merged 2 commits intosshnet:developfrom Aug 12, 2024
Merged
Use ExceptionDispatchInfo to retain call stack in AsyncResult.EndInvoke()#1470Rob-Hague merged 2 commits intosshnet:developfrom
Rob-Hague merged 2 commits intosshnet:developfrom
Conversation
Rob-Hague
approved these changes
Aug 12, 2024
Collaborator
Rob-Hague
left a comment
There was a problem hiding this comment.
This one often fails locally for me - in the past I looked at it and concluded the OpenSSH instance in the container was either erroring out or crashing (IIRC), but I did not work out why or whether it's our fault. Presumably it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to understand some flaky tests.
e.g.