Changed Private Key Regex to be more tolerant regarding new lines at end of key file#1344
Merged
WojciechNagorski merged 1 commit intosshnet:developfrom Mar 6, 2024
Merged
Conversation
Rob-Hague
approved these changes
Mar 5, 2024
Collaborator
Rob-Hague
left a comment
There was a problem hiding this comment.
Just curious, do you know how the key was generated?
Contributor
Author
Not really it was a key handed down to me from another department. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH.NET so far threw an unhelpful error message regarding an invalid key file if there was a new line between the key data and the end line. The changed regex now allows zero or one empty line.
This is now allowed