enable nullable on BaseClient and SftpClient#1339
Merged
Rob-Hague merged 2 commits intosshnet:developfrom Apr 17, 2024
Merged
Conversation
Rob-Hague
reviewed
Mar 4, 2024
Rob-Hague
reviewed
Mar 4, 2024
Rob-Hague
reviewed
Mar 4, 2024
mus65
force-pushed
the
sftpclientnullable
branch
from
effb908 to
fd605c4
Compare
Rob-Hague
approved these changes
Mar 5, 2024
Collaborator
Rob-Hague
left a comment
Rob-Hague
left a comment
There was a problem hiding this comment.
Thanks
For future reference, it is easier if you can avoid force-pushing once a review has started (merge develop into the PR branch to fix conflicts if possible). Then the new changes can more easily be seen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a start to get some feedback, I could do more of the public APIs.