Standardizes additional file types in .editorconfig#1266
Merged
WojciechNagorski merged 3 commits intosshnet:developfrom Dec 9, 2023
Merged
Standardizes additional file types in .editorconfig#1266WojciechNagorski merged 3 commits intosshnet:developfrom
WojciechNagorski merged 3 commits intosshnet:developfrom
Conversation
Formats xml, csproj, and props files
jacobslusser
requested review from
WojciechNagorski and
drieseng
as code owners
WojciechNagorski
approved these changes
Dec 9, 2023
Collaborator
WojciechNagorski
left a comment
WojciechNagorski
left a comment
There was a problem hiding this comment.
Amazing contribution! Thanks.
Welcome on board and we look forward to more!
Collaborator
|
Thanks @jacobslusser. Please do let it be known what your plans are - the library is gaining a bit of momentum at the moment, and we probably ought to sync up a bit or start assigning ourselves to issues etc. |
Closed
Collaborator
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR for this project and I didn't find any contributing guidelines, so please let me know if there is anything else I should do for submitting PRs.
TestResults/in the.gitignore. When the.slnfile was moved 2 months ago, this started puttingTestResults/folder in the root instead ofsrc/..xml,.csproj, and.propsfiles to.editorconfig. I also formatted those files according to these rules.visible=falseto thestylecop.jsonreference inDirectory.Build.props. Previously thestylecop.jsonfile would show in every project, but now will only show in the Solution Items.These are just simple things I found as I started getting acquainted with the code and running tests. I have bigger and better submissions planned but wanted to test the waters a little with the group and understand the process.