Conversation
vtexier
commented
Apr 24, 2020
- Translate Liked correctly (Capitalized)
- Add "new" translation
* Translate Liked correctly (Capitalized) * Add "new" translation
|
Ok, I have removed the "Liked" (Capitalized) causing conflict, and removed the non used "liked" key. I have left the missing "new" key, as if conflict it is simple to merge both. |
|
ah, that was not what I meant. I was happy to expire my PR and just let you do your French. you're better at it than I am :D |
|
one more question though: how did you determin that but I find it super hard to trace the call paths in the code base. |
|
Ooops, I had no idea "liked" was used elsewhere. But in Patchwork, I got a Capitalized "Liked" not translated in french, and I see a "liked" not Capitalized in the json file so I thought, hey that the "L" that is a typo and the translator do not find the key. But your finding prove me wrong... So let me know if you prefer i do all the french PR be myself. |
|
Sure, go ahead, that way at least it will be true French. :) |
