Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
write_source_position_infoand refactoredNiceDatabaseError::show_position_infoto use it for consistent file/line output.NicePositionedErrorand the constructordisplay_stmt_errorto wrap arbitraryanyhow::Errorwith aSourceSpanand source file for nicer display.ParsedStatement::StaticSimpleSelectto include aquery_positionand updated parsing and matching sites accordingly.execute_queries, map parameter binding and static-simple-select execution errors to include statement position usingwith_stmt_position, while preservingErrorWithStatussemantics.sqlpage.linkto return a clearanyhow!message for invalid parameters.test_display_stmt_error_includes_file_and_lineto verify the new positioned error formatting and adjusted existing tests to the updatedStaticSimpleSelectvariant.Testing
cargo testwhich executed unit tests includingtest_display_stmt_error_includes_file_and_lineandtest_quote_source_with_highlight, and the SQL parsing tests updated for theStaticSimpleSelectshape; all tests passed.Codex Task