Skip to content

Remove unused application startup call in AnnotationConfigApplicationContext#35570

Closed
Wars wants to merge 1 commit intospring-projects:mainfrom
Wars:main
Closed

Remove unused application startup call in AnnotationConfigApplicationContext#35570
Wars wants to merge 1 commit intospring-projects:mainfrom
Wars:main

Conversation

@Wars
Copy link
Contributor

@Wars Wars commented Oct 5, 2025

AbstractApplicationContext.applicationStartup can only be injected after the instance construction. This metrics point has no practical effect at present. I think it can be removed.

…thod of AnnotationConfigApplicationContext

AbstractApplicationContext.applicationStartup can only be injected after the instance construction. This metrics point has no practical effect at present. I think it can be removed.

Signed-off-by: Wars <wars@wars.cat>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 5, 2025
@bclozel bclozel self-assigned this Oct 5, 2025
@bclozel bclozel closed this in a32d0b1 Oct 6, 2025
@bclozel bclozel added type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 6, 2025
@bclozel bclozel added this to the 7.0.0-RC1 milestone Oct 6, 2025
@bclozel
Copy link
Member

bclozel commented Oct 6, 2025

Thanks @Wars this has been merged in main.

@bclozel bclozel changed the title perf(context): Remove the metrics code in the default construction method of AnnotationConfigApplicationContext Remove unused application startup call in AnnotationConfigApplicationContext Oct 6, 2025
izeye added a commit to izeye/spring-framework that referenced this pull request Feb 1, 2026
bclozel pushed a commit that referenced this pull request Feb 4, 2026
See gh-35570
Closes gh-36241

Signed-off-by: Johnny Lim <izeye@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants