adding vsix extension and cleanup code#11
Open
shayanypn wants to merge 1 commit intospread-the-code:masterfrom
Open
adding vsix extension and cleanup code#11shayanypn wants to merge 1 commit intospread-the-code:masterfrom
shayanypn wants to merge 1 commit intospread-the-code:masterfrom
Conversation
moshfeu
reviewed
Sep 16, 2020
Member
moshfeu
left a comment
moshfeu
left a comment
There was a problem hiding this comment.
This app becomes pretty :)
Excellent job!
Comment on lines
+1
to
+2
|
|
||
| export interface IExtension { |
Member
There was a problem hiding this comment.
Suggested change
| export interface IExtension { | |
| export interface IExtension { |
Or, in generally, run prettier :)
| const [isLoading, setIsLoading] = React.useState(false); | ||
| const [releases, setReleases] = React.useState([]); | ||
| const [chartOption, setChartOption] = React.useState(default_options); | ||
| const [model, setModel] = React.useState({ |
Member
There was a problem hiding this comment.
In the next version, try to set its type (to avoid anys later)
| ...prevStat, | ||
| loading: true, | ||
| })); | ||
| fetch(`https://api.github.com/repos/${user}/${repo}/releases`) |
Member
There was a problem hiding this comment.
Consider converting it to async / await
moshfeu
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.