Merged
Conversation
Contributor
ashah-splunk
commented
May 17, 2022
ashah-splunk
commented
- removed code specific for python version2
- removed six.py dependency which bridged support for python versions 2 and 3
- refactored code as per pylint suggestions
- used python3 features to improve both efficiency and performance
- removed future imports required to support py2 and py3 versions
- updated test cases to use py3 code
- updated CI test configuration to execute test cases in python 3.7 and 3.9 versions
- updated code to remove code deprecation warnings
Contributor
|
There are some test failures in latest and 8.1 runs, could we address them? |
shilpabijam
reviewed
Aug 11, 2023
shilpabijam
reviewed
Aug 11, 2023
jervin-splunk
suggested changes
Jan 30, 2024
jervin-splunk
left a comment
jervin-splunk
left a comment
There was a problem hiding this comment.
In addition to the places noted in the other comments, there are some lingering references to Python 2.7 and 2.6 which should likely be cleaned up as well in these files:
splunk-sdk-python/tests/README.md
splunk-sdk-python/scripts/test_specific.sh
splunk-sdk-python/README.md
maszyk99
reviewed
Feb 5, 2024
ichaer
suggested changes
Feb 20, 2024
Co-authored-by: Iuri Chaer <iuri.chaer@gmail.com>
- based on feedback updated code
ashah-splunk
changed the title
Contributor
|
I'm approving anticipating that the two pending comments will be resolved. They are not about particularly concerning issues, but they are trivial to implement and shouldn't be postponed. |
ichaer
approved these changes
Mar 14, 2024
- line separators were mistakenly updated, hence reverting it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.