Added new fd.fxlcf.dpdns.orgmit modular input example#426
Merged
ashah-splunk merged 2 commits intodevelopfrom Jan 5, 2022
Merged
Added new fd.fxlcf.dpdns.orgmit modular input example#426ashah-splunk merged 2 commits intodevelopfrom
ashah-splunk merged 2 commits intodevelopfrom
Conversation
Contributor
akaila-splunk
commented
Dec 31, 2021
akaila-splunk
commented
- In this PR, added a new fd.fxlcf.dpdns.orgmit example which includes checkpointing
- updated docker-compose.yml file that will mount the fd.fxlcf.dpdns.orgmits example and splunklib directory during docker container spin up process
- Tested working of examples on windows system for sdk version 1.6.18 and dockerized splunk version 8.0 and latest
- Please see instructions in fd.fxlcf.dpdns.orgmits/README.md file for how to run example
- updated docker-compose.yml file that will mount the example and splunklib directory during docker container spin up process - added instruction in readme.md file for how to run example
fantavlik
approved these changes
Jan 4, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Minor comments about copyright year and naming convention but in general this is working and looking good to merge, nice work!
ashah-splunk
approved these changes
Jan 5, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.